refactor: add missing translations in fa.json

[farshidinanloo]

fix Persian translation

Motivation

there is repetitive word in translation:

the correct one is like this:

[facebook-github-bot]

Hi @farshidinanloo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[netlify]

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 820f826

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612a724222e06000087c97a2

😎 Browse the preview: https://deploy-preview-5410--docusaurus-2.netlify.app

[ghost]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	97
🟢 Accessibility	98
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-5410--docusaurus-2.netlify.app/

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[lex111]

@farshidinanloo do you have a desire to provide a missing translation for other messages in this file? Maybe you could do that in this PR?

[slorber]

@massoudmaboudi can you help review this change?

[farshidinanloo]

@lex111 @massoudmaboudi
I try to add other translations and there is an issue the date it shows is wrong it's about 3 years before the current date.

[slorber]

Thanks but this is not exactly what we wanted 😅

Also if there is a problem with a date, please give much more details (screenshot, URL, date displayed when using English locale...) or something because it's hard to understand what you are talking about here. Have you noticed that it's written the date is simulated in dev?

[slorber]

please don't add/translate fields with ___DESCRIPTION, those are only in the base file to help you with additional context about the string to translate 🤪

Let me know how we can make this clearer

[slorber]

The missing translations"we talk about are keys that are already in this file, such as this one (theme.navbar.mobileVersionsDropdown.label)

You are not supposed to add keys from base.json, just make sure all the keys already there are properly translated

[slorber]

doesn't this lead to duplicate spaces?

Because theme.lastUpdated.atDate alrready contains a space (on purpose).

Other languages usually don't add spaces in theme.lastUpdated.lastUpdatedAtBy.

Please double-check for potentially duplicated spaces. I believe the correct form may be:

"theme.lastUpdated.lastUpdatedAtBy": "آخرین بروزرسانی{atDate}{byUser}",

The spaces are in {atDate}{byUser} because both of those variables are optional

[farshidinanloo]

@slorber
sorry about adding wrong translations 😁
and about spaces you are right this is true form: {atDate}{byUser}
I role back the changes and fix this spaces
and the date in the snapshot is 1397/07/22 but in Solar Hijri calendar we are in year 1400, I try to add demo link
thank you

[slorber]

Thanks

There are others untranslated strings in this file that you could also translate. I see these 2:

  "theme.docs.tagDocListPageTitle": "{nDocsTagged} with \"{tagName}\"",
  "theme.docs.tagDocListPageTitle.nDocsTagged": "One doc tagged|{count} docs tagged",

and the date in the snapshot is 1397/07/22 but in Solar Hijri calendar we are in year 1400, I try to add demo link

Yes that would be useful because I have no idea about this calendar what's the problem here 🤪

The code we use to format blog post dates is:

new Intl.DateTimeFormat("fa", {
      day: 'numeric',
      month: 'long',
      year: 'numeric',
      timeZone: 'UTC',
    }).format(new Date())

Isn't it correct?

Do you have another alternative JS solution using the Intl API to print the correct date?

[farshidinanloo]

@slorber
the date in your snapshot is correct.

but look at this demo I notice the date in local development and production is different when locale config is fa in local it show wrong Solar Hijri calendar as I said before and in production it show Gregorian date.

please look at this demo: https://docs-test-date.netlify.app/
source code: https://gitlab.com/farshidinanloo73/docusaurus-test

[slorber]

Thanks 👍

Please take a look at this other PR, suggesting to use slightly different fa translations: #5434

[slorber]

About the calendars, thanks, I was able to figure out the problem and opened a dedicated issue: #5440

[massoudmaboudi]

@slorber
Sorry for the late reply.
Yes, the changes are correct and you can merge them.