Skip to content

refactor: update Arabic and Persian translations#5434

Merged
slorber merged 7 commits into
facebook:mainfrom
3alisaki:3alisaki-patch-1
Aug 30, 2021
Merged

refactor: update Arabic and Persian translations#5434
slorber merged 7 commits into
facebook:mainfrom
3alisaki:3alisaki-patch-1

Conversation

@3alisaki
Copy link
Copy Markdown
Contributor

@3alisaki 3alisaki commented Aug 27, 2021

Motivation

Update Arabic and Persian translations for docusaurus classic theme

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Run yarn run start and check that the page http://localhost:3000/ is rendered properly.

Related PRs

none

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 27, 2021
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 27, 2021 •
edited
Loading

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 4c33975

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/612cb0d452fc020008508ded

😎 Browse the preview: https://deploy-preview-5434--docusaurus-2.netlify.app

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 27, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 96
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5434--docusaurus-2.netlify.app/

@slorber slorber mentioned this pull request Aug 30, 2021
Merged
@slorber slorber changed the title Update Arabic and Persian translations refactor: update Arabic and Persian translations Aug 30, 2021
slorber
slorber requested changes Aug 30, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farshidinanloo opened another PR for fa.json already: #5410

There's now a conflict, and some translations you both submitted do not match.
As I'm not really able to review these translations, please try to find an agreement together ;)

Comment thread packages/docusaurus-theme-classic/codeTranslations/ar.json Outdated
@3alisaki
Copy link
Copy Markdown
Contributor Author

3alisaki commented Aug 30, 2021

Hi, I'am updated this transition to match with @farshidinanloo transitions and fixed the spacing problem in ar.json too
you can now merge this pull request safly

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Aug 30, 2021
@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Aug 30, 2021

Thanks 👍 LGTM

@slorber slorber merged commit 74f060d into facebook:main Aug 30, 2021
@3alisaki 3alisaki deleted the 3alisaki-patch-1 branch August 30, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber slorber requested changes

@lex111 lex111 Awaiting requested review from lex111

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@3alisaki @slorber @facebook-github-bot