Pull memoizedInteractions from DataType instead of Fiber #1178
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I'll give this a quick test as soon as #1190 lands and if it works, I should be able to include it in the release I'm putting out today. |
| if (context && Object.keys(context).length === 0) { | ||
| context = null; | ||
| } | ||
| memoizedInteractions = publicInstance.memoizedInteractions; |
There was a problem hiding this comment.
We should be setting this for the HostRoot tag type actually. I can make this change.
|
Merged via f109374 Thanks! |
|
@bvaughn You're awesome! 🎉 Would've done the requested changes myself as the first thing tomorrow morning, but I'm happy that it's merged. Thanks again for looking at this PR 👍💯 |
|
Thank you! Just released as 3.4.2 |
3 participants
I'm currently integrating the profiler into preactjs as an experimental feature and noticed, that the profiler reads from the
memoizedInteractionsproperty directly from afiberinstead of fromevent.datalike it is done for all other properties.The integration is nearly done and this is the only inconsistency I've come across. I'm really impressed by the profiler and how easy it was to add support for it. It's really amazing 💯 👍
This PR fixes that by adding a
dataproperty to therootCommittedevent similar to how all other events work.