This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Added new tag values for 16.6+ #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
reviewed
Oct 22, 2018
backend/attachRendererFiber.js
Outdated
| } else if (semver.gte(version, '16.4.3-alpha')) { | ||
| ReactTypeOfWork = { | ||
| ClassComponent: 2, | ||
| ClassComponentLazy: 3, |
Contributor
There was a problem hiding this comment.
We didn't actually release these in public releases since they were behind the suspense flag. It seems like we can drop support for this tag now. I don't think RN is using lazy yet neither and if when they start, we'll be on 16.6 anyway. We don't support alphas continuously neither.
Contributor
Author
There was a problem hiding this comment.
Ah! I didn't know that the *Lazy tags never went out in a non-alpha. That's great, I'll remove them.
sebmarkbage
approved these changes
Oct 22, 2018
Contributor
Author
|
Removed the never-released "lazy" tags. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.