[iOS] Don't call sharedApplication in App Extension #25769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
The test failures look legit, would you mind looking into it? Thank you. |
Contributor
Author
|
@sammy-SC Emm, could you please list which test may related about this PR? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sammy-SC
approved these changes
Jul 26, 2019
Contributor
|
@zhongwuzw my apologies :) the failures seem to be unrelated. |
Collaborator
|
This pull request was successfully merged by @zhongwuzw in c5ea18f. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Aug 7, 2019
Summary: Fixes #25767 . ## Changelog [iOS] [Fixed] - Don't call sharedApplication in App Extension Pull Request resolved: #25769 Test Plan: RN works in App Extension. Reviewed By: cpojer Differential Revision: D16516104 Pulled By: sammy-SC fbshipit-source-id: 446fd1d88724b783b2afb2369783b9a85b5cc178
Contributor
|
I have the same issue with this line here: |
Contributor
|
@zhongwuzw @sammy-SC can you check this one out? #26077 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 19, 2019
Summary: Related to this bug: #25769 Note I also had to add to the bottom of my podfile because RCTLinking had APPLICATION_EXTENSION_API_ONLY='YES' by default somehow. ``` post_install do |installer| installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO' end end end ``` Pull Request resolved: #26077 Test Plan: Sandcastle should be sufficient. Reviewed By: shergin Differential Revision: D16860356 Pulled By: sammy-SC fbshipit-source-id: 02cb3fd3f977420ccdc2991f0c3666ab0186b7bf
lnikkila
pushed a commit
to Boulevard/react-native
that referenced
this pull request
Mar 6, 2020
Summary: Related to this bug: facebook#25769 Note I also had to add to the bottom of my podfile because RCTLinking had APPLICATION_EXTENSION_API_ONLY='YES' by default somehow. ``` post_install do |installer| installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO' end end end ``` Pull Request resolved: facebook#26077 Test Plan: Sandcastle should be sufficient. Reviewed By: shergin Differential Revision: D16860356 Pulled By: sammy-SC fbshipit-source-id: 02cb3fd3f977420ccdc2991f0c3666ab0186b7bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25767 .
Changelog
[iOS] [Fixed] - Don't call sharedApplication in App Extension
Test Plan
RN works in App Extension.