-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Don't call sharedApplication in App Extension #26077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
zhongwuzw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We need to replace all UIApplication.sharedApplication with RCTSharedApplication().
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ccorcos in 81733d9. When will my fix make it into a release? | Upcoming Releases |
Summary: Related to this bug: facebook#25769 Note I also had to add to the bottom of my podfile because RCTLinking had APPLICATION_EXTENSION_API_ONLY='YES' by default somehow. ``` post_install do |installer| installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO' end end end ``` Pull Request resolved: facebook#26077 Test Plan: Sandcastle should be sufficient. Reviewed By: shergin Differential Revision: D16860356 Pulled By: sammy-SC fbshipit-source-id: 02cb3fd3f977420ccdc2991f0c3666ab0186b7bf
Related to this bug: #25769
Note I also had to add to the bottom of my podfile because RCTLinking had APPLICATION_EXTENSION_API_ONLY='YES' by default somehow.