Skip to content

Fix dynamic_cast (RTTI) by adding key function to ShadowNodeWrapper and related classes #33500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kmagiera wants to merge 2 commits into from
Closed

Fix dynamic_cast (RTTI) by adding key function to ShadowNodeWrapper and related classes #33500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90618d2
Fix dynamic_cast (RTTI) by adding key function to ShadowNodeWrapper a…
kmagiera Mar 25, 2022
e5f8330
Add override for destructors to address review comments
kmagiera Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ReactCommon/react/renderer/uimanager/UIManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,20 @@

namespace facebook::react {

ShadowNodeWrapper::~ShadowNodeWrapper() {
// implementation is kept empty as there is nothing necessary to do in destrutor
// however, it still needs to exist in order to act as a "key function" for
// the ShadowNodeWrapper class -- this allow for RTTI to work properly across
// the library boundaries (i.e. dynamic_cast that is used by isHostObject method)
}

ShadowNodeListWrapper::~ShadowNodeListWrapper() {
// implementation is kept empty as there is nothing necessary to do in destrutor
// however, it still needs to exist in order to act as a "key function" for
// the ShadowNodeListWrapper class -- this allow for RTTI to work properly across
// the library boundaries (i.e. dynamic_cast that is used by isHostObject method)
}

static std::unique_ptr<LeakChecker> constructLeakCheckerIfNeeded(
RuntimeExecutor const &runtimeExecutor) {
#ifdef REACT_NATIVE_DEBUG
Expand Down
8 changes: 8 additions & 0 deletions ReactCommon/react/renderer/uimanager/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,21 @@ struct ShadowNodeWrapper : public jsi::HostObject {
ShadowNodeWrapper(SharedShadowNode shadowNode)
: shadowNode(std::move(shadowNode)) {}

// The below method needs to be out-of-line in order for the class to have
// at least one "key function" (see https://itanium-cxx-abi.github.io/cxx-abi/abi.html#vague-vtable)
~ShadowNodeWrapper() override;

ShadowNode::Shared shadowNode;
};

struct ShadowNodeListWrapper : public jsi::HostObject {
ShadowNodeListWrapper(SharedShadowNodeUnsharedList shadowNodeList)
: shadowNodeList(shadowNodeList) {}

// The below method needs to be out-of-line in order for the class to have
// at least one "key function" (see https://itanium-cxx-abi.github.io/cxx-abi/abi.html#vague-vtable)
~ShadowNodeListWrapper() override;

SharedShadowNodeUnsharedList shadowNodeList;
};

Expand Down