Skip to content

Enhance IP address retrieval for iOS devices in Metro bundler setup#41838

Closed
td-tomasz wants to merge 1 commit intofacebook:mainfrom
td-tomasz:patch-xcode-script
Closed

Enhance IP address retrieval for iOS devices in Metro bundler setup#41838
td-tomasz wants to merge 1 commit intofacebook:mainfrom
td-tomasz:patch-xcode-script

Conversation

@td-tomasz
Copy link
Copy Markdown

Summary:

After introducing this commit a56e5da script may fail in some circumstances.

Example:
When there is ip address available only for en1 and not en0, first "ipconfig" command in the loop fails with error code 1 and cancels whole script.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @td-tomasz-joniec!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2023

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against a4a3303

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,513,656 -24
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,884,239 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a8ca9b0
Branch: main

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2024

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 5, 2024
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale There has been a lack of activity on this issue and it may be closed soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants