Enhance IP address retrieval for iOS devices in Metro bundler setup#41838
Enhance IP address retrieval for iOS devices in Metro bundler setup#41838td-tomasz wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @td-tomasz-joniec! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Base commit: a8ca9b0 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Summary:
After introducing this commit a56e5da script may fail in some circumstances.
Example:
When there is ip address available only for en1 and not en0, first "ipconfig" command in the loop fails with error code 1 and cancels whole script.