ipconfig returns error code 1 if interface not configured

[broncha]

Summary:

I have only seen this happen in one of our Mac mini (M1). The interface en0 is not configured, and en1 is. When the script tries to find the IP address of the metro server, it cycles through interfaces 0 to 8. But, ipconfig on en0 returns with exit code 1 which causes the script to exit.

Changelog:

[INTERNAL] [CHANGED] - Do not exit the script when extracting IP address of metro server.

Test Plan:

ipconfig successfully cycles through the list of interfaces when the first interfaces are not configured.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,805,012	+4
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,200,486	-9
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: cd6755f
Branch: main

[broncha]

Just realized this is same as #41838

[dmytrorykun]

@broncha this PR #41839 was supposed to fix this issue, and it has been merged. Can you confirm that the issue still persists, and your PR fixes it.

[broncha]

@dmytrorykun I guess its the same result different approach. I dont have the machine in which this was failing right now. But it looks like the fix should work. I can close this PR, if you want, or keep it open until I verify the other fix tomorrow

[dmytrorykun]

@broncha If you could verify that the other fix worked, that would be really great. Let's keep this PR open until then.

[broncha]

@dmytrorykun I can confirm now that the other fix works as expected. Closing this now