Enhance IP address retrieval for iOS devices in Metro bundler setup#41839
Closed
Morritz wants to merge 1 commit intofacebook:mainfrom
Closed
Enhance IP address retrieval for iOS devices in Metro bundler setup#41839Morritz wants to merge 1 commit intofacebook:mainfrom
Morritz wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: 8ef807b |
Contributor
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@dmytrorykun merged this pull request in 9f28616. |
huntie
pushed a commit
that referenced
this pull request
Dec 27, 2023
…41839) Summary: After introducing this commit a56e5da script may fail in some circumstances. Example: When there is IP address available only for en1 and not en0, first "ipconfig" command in the loop fails with error code 1 and cancels whole script. ## Changelog: [iOS] [Fixed] - [enhance IP address retrieval for iOS devices in Metro bundler setup](6a351db) Pull Request resolved: #41839 Reviewed By: christophpurrer Differential Revision: D51979040 Pulled By: dmytrorykun fbshipit-source-id: 0f6f42a7dd70bac012875ffae5d651b74b225c94
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After introducing this commit a56e5da script may fail in some circumstances.
Example:
When there is IP address available only for en1 and not en0, first "ipconfig" command in the loop fails with error code 1 and cancels whole script.
Changelog:
[iOS] [Fixed] - enhance IP address retrieval for iOS devices in Metro bundler setup