Fix CocoaPods crash with nonexistent files#41848
Fix CocoaPods crash with nonexistent files#41848tyronet-sportsbet wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Apologies for letting this die on the vine; we're still trying to get the CLA signed at the corporate level and this takes time. In the meantime, I've noticed this patch is now no longer necessary due to #42637, so I'm closing this PR for now. If that ATS config patch system ever makes its way back in though it's worth keeping in mind this particular use case. Thanks! |
Summary:
Xcode Projects can contain files that don't exist until build time. If one of these happens to end with
Info.plist(as is this case with our project), CocoaPods will crash, sinceutils.rbtries to patch all of these with ATS stuff. In the case where these files don't exist on disk, this CocoaPods post-install job should simply ignore those file references.Changelog:
[IOS] [FIXED] - Fixed CocoaPods crashing when Xcode project contains non-existent -Info.plist file
Test Plan:
I've refactored the
apply_ats_configmethod to also accept afile_managerparam so that the file manager can be mocked in the unit tests. I have confirmed that the unit tests continue to pass, and also when I have applied the changes toutils.rbin react native in our main project'snode_modules, apod installnow no longer crashes.