[ios] Remove ATS config patch from react_native_post_install#42637
Closed
gabrieldonadel wants to merge 1 commit intofacebook:mainfrom
Closed
[ios] Remove ATS config patch from react_native_post_install#42637gabrieldonadel wants to merge 1 commit intofacebook:mainfrom
gabrieldonadel wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Jan 24, 2024
Contributor
|
TY for submitting this PR! |
Contributor
|
@cipolleschi merged this pull request in 41c601e. |
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
Summary: This PR removes the `apply_ats_config` function of ReactNativePodsUtils that was used inside `react_native_post_install` because it was preventing users from configuring `NSAllowsArbitraryLoads` to true in their projects, especially when building in CI as the plist file would be reset after running pod install. [IOS] [CHANGED] - Remove ATS config patch from react_native_post_install Pull Request resolved: #42637 Test Plan: Edit `Info.plist`, run `pod install` and check if changes have not been overwritten Reviewed By: cortinico Differential Revision: D53048299 Pulled By: cipolleschi fbshipit-source-id: 8dc335fae2e05a62daf931a50fa3f7a314e76a2e
This was referenced Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes the
apply_ats_configfunction of ReactNativePodsUtils that was used insidereact_native_post_installbecause it was preventing users from configuringNSAllowsArbitraryLoadsto true in their projects, especially when building in CI as the plist file would be reset after running pod install.Changelog:
[IOS] [CHANGED] - Remove ATS config patch from react_native_post_install
Test Plan:
Edit
Info.plist, runpod installand check if changes have not been overwritten