Skip to content

Do not mutate output of flattenStyle #45340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javache wants to merge 1 commit into from
Closed

Do not mutate output of flattenStyle #45340

javache wants to merge 1 commit into from

Conversation

@javache
Copy link
Member

@javache javache commented Jul 9, 2024

Summary:
flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Differential Revision: D59515063

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 9, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

This was referenced Jul 9, 2024
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
ca21270 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from 4941727 to ca21270 Compare July 9, 2024 09:47
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
f766a09 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from ca21270 to f766a09 Compare July 9, 2024 09:53
javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
58871dd 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from f766a09 to 58871dd Compare July 9, 2024 10:29
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
96d7b1e 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from 58871dd to 96d7b1e Compare July 9, 2024 10:53
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
7a7e5df 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from 96d7b1e to 7a7e5df Compare July 9, 2024 11:01
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
b835a21 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from 7a7e5df to b835a21 Compare July 9, 2024 11:42
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

javache added a commit to javache/react-native that referenced this pull request Jul 9, 2024
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
4ad5c72 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@javache javache force-pushed the export-D59515063 branch from b835a21 to 4ad5c72 Compare July 9, 2024 12:24
@javache @facebook-github-bot
Do not mutate output of flattenStyle (facebook#45340)
593e0bf 
Summary:
Pull Request resolved: facebook#45340

flattenStyle may return an object which is already frozen (in development), so it is incorrect to further mutate this.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D59515063
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request was exported from Phabricator. Differential Revision: D59515063

@javache javache force-pushed the export-D59515063 branch from 4ad5c72 to 593e0bf Compare July 9, 2024 12:29
@javache javache mentioned this pull request Jul 9, 2024
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2024

This pull request has been merged in ef2e941.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 9, 2024
@github-actions
Copy link

github-actions bot commented Jul 9, 2024

This pull request was successfully merged by @javache in ef2e941.

When will my fix make it into a release? | How to file a pick request?

@meetdhanani17
Copy link
Contributor

meetdhanani17 commented Jul 9, 2024

Also Fix for TextInput.js and TextOptimized.js

@javache javache deleted the export-D59515063 branch July 9, 2024 16:05
@cortinico
Copy link
Contributor

cortinico commented Jul 9, 2024

Also Fix for TextInput.js and TextOptimized.js

@meetdhanani17 feel free to send out a follow-up PR for that

@javache
Copy link
Member Author

javache commented Jul 10, 2024

Follow-up for this in #45348

@meetdhanani17
Copy link
Contributor

meetdhanani17 commented Aug 7, 2024

Also Fix for TextInput.js and TextOptimized.js

@meetdhanani17 feel free to send out a follow-up PR for that

Follow-up for one remaining in #45932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@javache @facebook-github-bot @meetdhanani17 @cortinico