Skip to content

Conversation

@meetdhanani17
Copy link
Contributor

Summary:

Fixes #45285
object created by StyleSheet.create provide readonly object and it cannot be changeable for farther value or type change according to native requirements, so I have added condition in flattenStyle function, if it's readonly than convert into editable object

Changelog:

[GENERAL] [FIXED] - fixed fontWeight number value error for android (java.lang.Double cannot be cast to java.lang. String)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2024
@github-actions
Copy link

github-actions bot commented Jul 9, 2024

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against f277fcb

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 9, 2024
@javache
Copy link
Member

javache commented Jul 9, 2024

Apologies, this is already being addressed in #45340 (I have some additional changes on top of this I want to make)

@javache javache closed this Jul 9, 2024
@meetdhanani17
Copy link
Contributor Author

Also Fix for TextInput.js and TextOptimized.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] fontWeight number value error if not in an array

3 participants