Skip to content

Fix: fontWeight issue of double in android #45342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meetdhanani17 wants to merge 4 commits into from
Closed

Fix: fontWeight issue of double in android #45342

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13165f2
fix fontweight issue of double in android
meetdhanani17 Jul 9, 2024
2c7d78f
fix typo for overrideStyle
meetdhanani17 Jul 9, 2024
72b0b83
fix typo for overrideStyle
meetdhanani17 Jul 9, 2024
f277fcb
Update Text.js
meetdhanani17 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/react-native/Libraries/Text/Text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,25 +223,29 @@ const TextLegacy: React.AbstractComponent<
}

let _selectable = selectable;
const processedStyle = flattenStyle(_style);
let processedStyle = flattenStyle(_style);
if (processedStyle != null) {
const overrideStyle = null;
if (typeof processedStyle.fontWeight === 'number') {
// $FlowFixMe[cannot-write]
processedStyle.fontWeight = processedStyle.fontWeight.toString();
overrideStyle = overrideStyle ?? {};
overrideStyle.fontWeight = processedStyle.fontWeight.toString();
}

if (processedStyle.userSelect != null) {
_selectable = userSelectToSelectableMap[processedStyle.userSelect];
// $FlowFixMe[cannot-write]
delete processedStyle.userSelect;
overrideStyle = overrideStyle ?? {};
overrideStyle.userSelect = undefined;
}

if (processedStyle.verticalAlign != null) {
// $FlowFixMe[cannot-write]
processedStyle.textAlignVertical =
overrideStyle.textAlignVertical =
verticalAlignToTextAlignVerticalMap[processedStyle.verticalAlign];
// $FlowFixMe[cannot-write]
delete processedStyle.verticalAlign;
overrideStyle.verticalAlign = undefined;
}

if (overrideStyle != null) {
processedStyle = {...processedStyle, ...overrideStyle};
}
}

Expand Down