Converge component's bespoke StringEnumTypeAnnotation into StringLiteralUnionTypeAnnotation #48343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67427656 |
…acebook#48318) Summary: These structures were the same, but the component side didn't use generics and just had duplicates. Making a base one to be shared. I need to follow up to this and constrain the types that components allow. Changelog: [Internal] Reviewed By: javache Differential Revision: D67371894
…ralUnionTypeAnnotation (facebook#48343) Summary: components store unions as 'StringEnumTypeAnnotation' even though it isn't actually a union, it's a literal. Native Modules store these as 'StringLiteralTypeAnnotation' so this converges those and reuses the same types. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D67427656
elicwhite
force-pushed
the
export-D67427656
branch
from
7722d60 to
c33768c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67427656 |
Contributor
|
This pull request has been merged in 9e0a7e3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
components store unions as 'StringEnumTypeAnnotation' even though it isn't actually a union, it's a literal.
Native Modules store these as 'StringLiteralTypeAnnotation' so this converges those and reuses the same types.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D67427656