Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode #48586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D68005037
branch
from
6009d5c to
7f895bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 15, 2025
…ng with AndroidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D68005037
branch
from
7f895bc to
5fdd97d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 16, 2025
…ng with AndroidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D68005037
branch
from
5fdd97d to
669d55a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D68005037
branch
from
669d55a to
61ce1e7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
force-pushed
the
export-D68005037
branch
from
61ce1e7 to
06ba2fd
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
…ed with AndroidTextInputShadowNode (facebook#48585) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to determine updateStateIfNeeded with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Reviewed By: javache Differential Revision: D68004755
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
christophpurrer
force-pushed
the
export-D68005037
branch
from
06ba2fd to
9213ef4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68005037 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Feb 15, 2025
…droidTextInputShadowNode (facebook#48586) Summary: [Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode As a preparation for facebook#48165 this aligns the implementation of those 2 methods Differential Revision: D68005037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Align logic in BaseTextInputShadowNode to getAttributedString with AndroidTextInputShadowNode
As a preparation for #48165 this aligns the implementation of those 2 methods
Differential Revision: D68005037