-
Notifications
You must be signed in to change notification settings - Fork 25.1k
# Fixed Type Conversion Error in DynamicEventPayload #52525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# Fixed Type Conversion Error in DynamicEventPayload #52525
Conversation
|
Hi @HariniMalothu17! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This pull request was successfully merged by Harini Malothu in ff38d59 When will my fix make it into a release? | How to file a pick request? |
Summary: Resolves microsoft/react-native-windows#14797 We were facing a type conversion error in the DynamicEventPayload::extractValue() method. The function signature declares a return type of std::optional<double>, but when handling INT64 values, but when handling `INT64` values, the code was directly returning `dynamic.asInt()` without proper type conversion We faced the issue while integrating microsoft/react-native-windows#14791 ## Changelog: [General][Fixed] Pull Request resolved: facebook#52525 Test Plan: The fix involved wrapping the dynamic.asInt() call with static_cast<double>(), creating the corrected line: return static_cast<double>(dynamic.asInt()) Tested E2E in RNW Reviewed By: andrewdacenko Differential Revision: D78083842 Pulled By: rshest fbshipit-source-id: 8dbedd67fa7c21e89b863d8b1bc7b9e0d7978b9f
Summary:
Resolves microsoft/react-native-windows#14797
We were facing a type conversion error in the DynamicEventPayload::extractValue() method. The function signature declares a return type of std::optional, but when handling INT64 values, but when handling
INT64values, the code was directly returningdynamic.asInt()without proper type conversionWe faced the issue while integrating microsoft/react-native-windows#14791
Changelog:
[General][Fixed]
Test Plan:
The fix involved wrapping the dynamic.asInt() call with static_cast(), creating the corrected line: return static_cast(dynamic.asInt())
Tested E2E in RNW