Skip to content

Conversation

@vineethkuttan
Copy link
Contributor

@vineethkuttan vineethkuttan commented Jun 17, 2025

Description

Integrate RN Nightly Build 0.80.0-nightly-20250331-398ac1f71

Commit Range

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

@chiaramooney
Copy link
Contributor

A few tips for the errors you're hitting:

@anupriya13 anupriya13 requested a review from Copilot June 18, 2025 06:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Integrate the React Native 0.80.0-nightly-20250331-398ac1f71 build into the Windows fork, updating type definitions, adding new event props, and bumping package references.

  • Modernize Flow/TS type syntax across Win32 libraries
  • Introduce onPressMove callback to Pressable and relax its children prop
  • Bump RN nightly package versions, Metro versions, Flow version, and override hashes

Reviewed Changes

Copilot reviewed 82 out of 82 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/@office-iss/react-native-win32/src-win/Libraries/Pressability/Pressability.win32.js Switch to GestureResponderEvent['nativeEvent'] syntax
packages/@office-iss/react-native-win32/src-win/Libraries/Network/RCTNetworking.win32.js Update listener type to AccessibilityEventDefinitions[K]
packages/@office-iss/react-native-win32/src-win/Libraries/NativeComponent/BaseViewConfig.win32.js Add experimental_accessibilityOrder attribute
packages/@office-iss/react-native-win32/src-win/Libraries/Components/View/ViewPropTypes.win32.js Import React and use React.Node, add TV props
packages/@office-iss/react-native-win32/src-win/Libraries/Components/View/ViewAccessibility.win32.js Extend AccessibilityRole union with string
packages/@office-iss/react-native-win32/src-win/Libraries/Components/Touchable/TouchableNativeFeedback.win32.js Cast findHostInstance_DEPRECATED with <$FlowFixMe>
packages/@office-iss/react-native-win32/src-win/Libraries/Components/TextInput/TextInputState.win32.js Cast findNodeHandle with <$FlowFixMe>
packages/@office-iss/react-native-win32/src-win/Libraries/Components/TextInput/TextInput.win32.js Change several export type to non-exported type
packages/@office-iss/react-native-win32/src-win/Libraries/Components/Pressable/Pressable.win32.js Relax children to optional and add onPressMove
packages/@office-iss/react-native-win32/src-win/Libraries/Components/AccessibilityInfo/AccessibilityInfo.win32.js Update handler signature type
packages/@office-iss/react-native-win32/package.json Bump RN nightly, Metro, and other dependencies
packages/@office-iss/react-native-win32/overrides.json Update base nightly version and override hashes
packages/@office-iss/react-native-win32/.flowconfig Upgrade Flow version
packages/@office-iss/react-native-win32-tester/package.json Bump RN nightly in tester dependencies
packages/@office-iss/react-native-win32-tester/overrides.json Update tester base version
change/*.json (various) Add change files for prerelease/patch coordination
Comments suppressed due to low confidence (2)

packages/@office-iss/react-native-win32/src-win/Libraries/Components/TextInput/TextInput.win32.js:74

  • The TextInputChangeEventData type was changed from export type to a non-exported type, which removes it from the public API surface. Please re-add export to maintain backward compatibility for consumers who reference this type.
type TextInputChangeEventData = $ReadOnly<{

packages/@office-iss/react-native-win32/src-win/Libraries/Components/TextInput/TextInput.win32.js:114

  • The TextInputFocusEventData type was changed from export type to a non-exported type, which may break code relying on that export. Restore export to preserve the public type definition.
type TextInputFocusEventData = TargetEvent;

@vineethkuttan vineethkuttan force-pushed the rn-integrate-march-vineethkuttan branch from 115f0c7 to 4638257 Compare June 18, 2025 15:30
@vineethkuttan vineethkuttan force-pushed the rn-integrate-march-vineethkuttan branch from 4638257 to 386871d Compare June 18, 2025 17:35
@vineethkuttan vineethkuttan marked this pull request as ready for review June 18, 2025 18:09
@vineethkuttan vineethkuttan requested review from a team as code owners June 18, 2025 18:09
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small comment to address. Otherwise looks good, great work!

@vineethkuttan vineethkuttan requested a review from acoates-ms June 19, 2025 00:13
@vineethkuttan vineethkuttan force-pushed the rn-integrate-march-vineethkuttan branch from e983be2 to d173709 Compare June 19, 2025 06:43
@vineethkuttan vineethkuttan force-pushed the rn-integrate-march-vineethkuttan branch from 0beb262 to ac27183 Compare June 19, 2025 17:01
},
{
"type": "derived",
"file": "src-win/Libraries/Utilities/DeviceInfo.win32.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to remove the DeviceInfo.win32.js fork you'll need to delete the file, call npx react-native-platform-override remove to remove the override and then delete this line

<PROJECT_ROOT>/Libraries/Utilities/DeviceInfo.js
to fix the flow errors

@vineethkuttan vineethkuttan force-pushed the rn-integrate-march-vineethkuttan branch from 5a155a4 to ac27183 Compare June 19, 2025 17:37
@vineethkuttan vineethkuttan merged commit ca29f4e into microsoft:main Jun 19, 2025
58 checks passed
@vineethkuttan vineethkuttan deleted the rn-integrate-march-vineethkuttan branch July 3, 2025 14:44
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Jul 11, 2025
Summary:
Resolves microsoft/react-native-windows#14797
We were facing a type conversion error in the DynamicEventPayload::extractValue() method. The function signature declares a return type of std::optional<double>, but when handling INT64 values, but when handling `INT64` values, the code was directly returning `dynamic.asInt()` without proper type conversion
We faced the issue while integrating microsoft/react-native-windows#14791
## Changelog:
[General][Fixed]

Pull Request resolved: #52525

Test Plan:
The fix involved wrapping the dynamic.asInt() call with static_cast<double>(), creating the corrected line: return static_cast<double>(dynamic.asInt())

Tested E2E in RNW

Reviewed By: andrewdacenko

Differential Revision: D78083842

Pulled By: rshest

fbshipit-source-id: 8dbedd67fa7c21e89b863d8b1bc7b9e0d7978b9f
kikoso pushed a commit to kikoso/react-native that referenced this pull request Aug 26, 2025
Summary:
Resolves microsoft/react-native-windows#14797
We were facing a type conversion error in the DynamicEventPayload::extractValue() method. The function signature declares a return type of std::optional<double>, but when handling INT64 values, but when handling `INT64` values, the code was directly returning `dynamic.asInt()` without proper type conversion
We faced the issue while integrating microsoft/react-native-windows#14791
## Changelog:
[General][Fixed]

Pull Request resolved: facebook#52525

Test Plan:
The fix involved wrapping the dynamic.asInt() call with static_cast<double>(), creating the corrected line: return static_cast<double>(dynamic.asInt())

Tested E2E in RNW

Reviewed By: andrewdacenko

Differential Revision: D78083842

Pulled By: rshest

fbshipit-source-id: 8dbedd67fa7c21e89b863d8b1bc7b9e0d7978b9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants