Release script no longer auto-updates peerDependencies react version #11292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gaearon
approved these changes
Oct 20, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Can we make it explicitly set ^major.0.0? In case somebody updates by mistake. Or for 17 etc.
Contributor
Author
|
Sure. Easy enough. |
Contributor
Author
|
Okay. I updated it to only adjust the peer dependency if the major versions don't match (allowing us to still manually bump the minor/bugfix if we choose to). Also updated the path for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion, the team has decided not to automatically increment the
reactversion specified by projectpeerDependencieswhen we release minor updates. This PR removes that logic from the release script.(Going forward, we'll have to rely on Flow to notify us of upcoming changes and manually update the dependency before running the release script.)
Resolves #11278