Skip to content

Release script no longer auto-updates peerDependencies react version #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 2 commits into from
Oct 20, 2017
Merged

Release script no longer auto-updates peerDependencies react version #11292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d344c5
Release script no longer auto-updates peerDependencies react version
bvaughn Oct 19, 2017
0bdaa47
Release script ensures peer dep matches release major verion
bvaughn Oct 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/release/build-commands/update-package-versions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const update = async ({cwd, dry, version}) => {
await writeJson(packagePath, rootPackage, {spaces: 2});

// Update ReactVersion source file
const reactVersionPath = join(cwd, 'packages/shared/src/ReactVersion.js');
const reactVersionPath = join(cwd, 'packages/shared/ReactVersion.js');
const reactVersion = readFileSync(reactVersionPath, 'utf8').replace(
/module\.exports = '[^']+';/,
`module.exports = '${version}';`
Expand All @@ -42,8 +42,15 @@ const update = async ({cwd, dry, version}) => {
}

if (project !== 'react') {
json.peerDependencies.react = `^${version}`;
const peerVersion = json.peerDependencies.react.replace('^', '');

// Release engineers can manually update minor and bugfix versions,
// But we should ensure that major versions always match.
if (semver.major(version) !== semver.major(peerVersion)) {
json.peerDependencies.react = `^${semver.major(version)}.0.0`;
}
}

await writeJson(path, json, {spaces: 2});
};
await Promise.all(projects.map(updateProjectPackage));
Expand Down