Fork legacy-events folder into react-dom and react-native #19228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Jul 1, 2020
| @@ -0,0 +1,66 @@ | |||
| /** | |||
Collaborator
Author
There was a problem hiding this comment.
Everything below is just folder copy paste. I made no changes.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bddd4c5:
|
trueadm
approved these changes
Jul 1, 2020
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
I gave it a quick glance over, given the size of changes, and things look good. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes top-level
legacy-events/*and instead copies all files into two folders:react-dom/src/legacy-events/*react-native-renderer/src/legacy-events/*I updated all the import references.
This gives us a clear separation and lets us remove most of that from the DOM folder when we flip the flag.