Enable modern event system and delete dead code #19230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d04cd4d:
|
gaearon
commented
Jul 1, 2020
| it('flushes pending interactive work before extracting event handler', () => { | ||
| container = document.createElement('div'); | ||
| const root = ReactDOM.unstable_createRoot(container); | ||
| const root = ReactDOM.createRoot(container); |
Collaborator
Author
There was a problem hiding this comment.
I didn't change this one. Git just thinks I renamed it whereas I actually deleted old test.
Kind of confusing why it uses unprefixed name. I thought that doesn't work anymore.
Details of bundled changes.Comparing: e3f4eb7...d04cd4d react-dom
react-native-renderer
ReactDOM: size: -24.8%, gzip: -21.7% Size changes (experimental) |
Details of bundled changes.Comparing: e3f4eb7...d04cd4d react-dom
react-native-renderer
ReactDOM: size: -24.8%, gzip: -21.7% Size changes (stable) |
trueadm
reviewed
Jul 1, 2020
trueadm
reviewed
Jul 1, 2020
trueadm
reviewed
Jul 1, 2020
trueadm
reviewed
Jul 1, 2020
trueadm
suggested changes
Jul 1, 2020
Collaborator
Author
|
Hmm. I'm not sure I follow. The native renderer uses the legacy system, right? We don't yet remove pooling on RN either. |
trueadm
approved these changes
Jul 1, 2020
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Ah , ignore me. I got confused by which file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #19228, I forked legacy event system folder for DOM and Native.
In this PR, I am removing the
enableModernEventSystemflag altogether:enableModernEventSystem = true.enableModernEventSystem = false.This enables us to remove a bunch of files and codepaths in DOM. There's more to do there but this is already fairly invasive so I will send the rest as follow-ups.
You should review without whitespace. https://github.com/facebook/react/pull/19230/files?diff=split&w=1