Added jasmine matcher that expects calls to console.warn. #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/ReactTestUtils.js
Outdated
Member
There was a problem hiding this comment.
use spyOn(console, 'warn') (andCallThrough maybe), not the mocks module. That gets rid of the try/finally because we don't need to reset console.
Contributor
Author
There was a problem hiding this comment.
Can't spy twice, so as per discussion, using mocks.
jimfb
force-pushed
the
testutils-consolemock
branch
from
ac4fb42 to
bd4aff0
Compare
Member
|
Let's do it. |
jimfb
added a commit
that referenced
this pull request
Jan 7, 2015
Added jasmine matcher that expects calls to console.warn.
zpao
added a commit
that referenced
this pull request
Jan 15, 2015
Revert "Merge pull request #2814 from jsfb/testutils-consolemock"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jasmine matcher that expects calls to console.warn.