Revert "Merge pull request #2814 from jsfb/testutils-consolemock" #2865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This also shouldn't have been a part of ReactTestUtils since that's stand-alone from jasmine and can be used by other test frameworks. It could've been a stand-alone module or pulled into jest directly. |
zpao
added a commit
that referenced
this pull request
Jan 15, 2015
Revert "Merge pull request #2814 from jsfb/testutils-consolemock"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9514861, reversing
changes made to cdec837.
This is causing problems internally due to build process. This is the fastest fix. We aren't using the matcher anywhere yet so it's a simple revert.