-
Notifications
You must be signed in to change notification settings - Fork 50.4k
ESLint coverage #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint coverage #3123
Conversation
|
I totally get where you're coming from but let's leave this for now. We (FB) still use jshint internally so these actually help keep things a bit quieter there. I'd be fine dropping the jshint things from everything not in |
|
@zpao now ESLint is everywhere except |
grunt/config/browserify.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert these changes. This is intended (to match the formatting of the license as it appears in regular source files).
|
Overall, herculean effort. Thanks! Just a few smaller things inline I think. Also, it looks like something got weird with your branching (or GitHub broke). Can you rebase and whatever you need to get that sorted out. |
Wow.. it's really weird. I'll check it |
512c90c to
2c0f257
Compare
|
@zpao rebased |
439b0ac to
862f7d6
Compare
|
about commit weirdness. I was playing with this script trying to change my name from chico to my real name but I thought I was playing in my test repo and so I broke git history. Then I pushed my broken react branch to my remote next day. So I solved that by |
|
Alright, lets do it. Thanks for fixing the commit weirdness! This will definitely be useful and I know it was painstaking work, so we really appreciate it. |
No description provided.