lint from root #3209
Merged
lint from root #3209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintignore
Outdated
Contributor
Author
There was a problem hiding this comment.
Not sure about comment that was here before. Grunt task didn't lint vendor/ before but comment was about vendor/fbtransform/syntax.js only.
Member
There was a problem hiding this comment.
It does as of #3206.
Edit: let's not ignore all of vendor but be meaningful about what we do ignore.
chicoxyzzy
force-pushed
the
eslint-everywhere
branch
from
85dc2b1 to
466f4fa
Compare
Contributor
|
cc @zpao |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this completes #3123