Skip to content

Expose component instance in shallow rendering #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sophiebits merged 1 commit into from
Oct 7, 2015
Merged

Expose component instance in shallow rendering #4918

sophiebits merged 1 commit into from
Oct 7, 2015

Conversation

@glenjamin
Copy link
Contributor

@glenjamin glenjamin commented Sep 20, 2015

Fixes #4056

@koba04
Copy link
Contributor

koba04 commented Sep 20, 2015

What is the reason for exposing as a new API?
It seems to be better to return by ReactShallowRenderer.render because of consistency between ReadDOM.render.

@glenjamin
Copy link
Contributor Author

glenjamin commented Sep 23, 2015

Mostly for "consistency" with the other way of getting info out of a shallow render: getRenderOutput()

@sebmarkbage sebmarkbage added this to the 0.15 milestone Oct 6, 2015
sophiebits added a commit that referenced this pull request Oct 7, 2015
@sophiebits
Merge pull request #4918 from glenjamin/shallow-getinstance
8ebbb78 
Expose component instance in shallow rendering
@sophiebits sophiebits merged commit 8ebbb78 into facebook:master Oct 7, 2015
@zpao zpao mentioned this pull request Nov 6, 2015
Merged
@viniciusbo viniciusbo mentioned this pull request Apr 14, 2016
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@glenjamin @koba04 @sophiebits @sebmarkbage @facebook-github-bot