Fuzz the Block-Level Sequence Producer API#3437
Merged
embg merged 2 commits intofacebook:devfrom Jan 20, 2023
Merged
Conversation
embg
changed the title
terrelln
approved these changes
Jan 19, 2023
Contributor
terrelln
left a comment
terrelln
left a comment
There was a problem hiding this comment.
Looks good, just one minor suggestion
Co-authored-by: Nick Terrell <nickrterrell@gmail.com>
embg
changed the title
embg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds external matchfinder registration to
FUZZ_setRandomParameters(). This allows the fuzzers to catch 3/4 of the bugs from #3433. (The 4th bug is captured in zstreamtest.c). I ran the fuzzers overnight and did not find any new crashes, only timeouts and one OOM (these don't indicate real bugs in zstd).