Provide an interface for fuzzing sequence producer plugins#3551
Merged
embg merged 1 commit intofacebook:devfrom Mar 28, 2023
Merged
Provide an interface for fuzzing sequence producer plugins#3551embg merged 1 commit intofacebook:devfrom
embg merged 1 commit intofacebook:devfrom
Conversation
Cyan4973
reviewed
Mar 16, 2023
terrelln
approved these changes
Mar 17, 2023
Contributor
terrelln
left a comment
There was a problem hiding this comment.
Looks good. Can you also add the documentation about how to build & run the fuzzer in seq_prod_fuzz_example/README.md?
|
Hi @embg, now only simple_round_trip is enabled, will other fuzzers be enabled in this PR or other new PRs? If other fuzzers are ready, could you @ me so that I can try them ASAP? |
Contributor
Author
|
@GarenJian-Intel Added support for the following fuzzers: Also, responded to all nits from @terrelln. Merging after CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzz-testing for the external sequence producer API was introduced in PR #3437. However, the setup in #3437 only allows fuzzers to exercise the implementation of the API on the libzstd side (the code in the core zstd library which interacts with a plugin). This PR allows us to fuzz the plugin code itself, which is a requirement for us to use plugins (such as hardware accelerators) in production.
Here is an example showing how this new interface allows us to link plugin code into the fuzzer build: