contrib/pzstd/Makefile: drop -std=c++11 to fix build of the test#3499
Closed
ldv-alt wants to merge 1 commit intofacebook:devfrom
Closed
contrib/pzstd/Makefile: drop -std=c++11 to fix build of the test#3499ldv-alt wants to merge 1 commit intofacebook:devfrom
ldv-alt wants to merge 1 commit intofacebook:devfrom
Conversation
It's not just strange to require an older version of the language
standard that the compiler supports by default, it's also blocks
building the test which requires a newer version of the language
standard nowadays:
In file included from /usr/include/gtest/gtest-message.h:57,
from /usr/include/gtest/gtest-assertion-result.h:46,
from /usr/include/gtest/gtest.h:64,
from utils/test/ScopeGuardTest.cpp:11:
/usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.
Contributor
|
cc @terrelln |
felixhandte
added a commit
to felixhandte/zstd
that referenced
this pull request
Mar 27, 2023
Rather than remove the flag entirely, as proposed in facebook#3499, this commit uses the newest C++ standard the compiler supports. This retains the selection of using only standardized features (excluding GNU extensions) and keeps the recency requirements of the codebase explicit. Tested with various versions of `g++` and `clang++`.
Contributor
|
We've landed a different fix to this issue, so I'm going to close this PR. Thanks for reporting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not just strange to require an older version of the language standard that the compiler supports by default, it's also blocks building the test which requires a newer version of the language standard nowadays:
In file included from /usr/include/gtest/gtest-message.h:57,
from /usr/include/gtest/gtest-assertion-result.h:46,
from /usr/include/gtest/gtest.h:64,
from utils/test/ScopeGuardTest.cpp:11:
/usr/include/gtest/internal/gtest-port.h:270:2: error: #error C++ versions less than C++14 are not supported.