[contrib/pzstd] Select -std=c++11 When Default is Older#3574
Merged
felixhandte merged 2 commits intofacebook:devfrom Mar 27, 2023
Merged
[contrib/pzstd] Select -std=c++11 When Default is Older#3574felixhandte merged 2 commits intofacebook:devfrom
-std=c++11 When Default is Older#3574felixhandte merged 2 commits intofacebook:devfrom
Conversation
Rather than remove the flag entirely, as proposed in facebook#3499, this commit uses the newest C++ standard the compiler supports. This retains the selection of using only standardized features (excluding GNU extensions) and keeps the recency requirements of the codebase explicit. Tested with various versions of `g++` and `clang++`.
Contributor
|
What benefit is there in selecting a C++ standard newer than C++11 ? |
Contributor
Author
|
As noted in #3499, newer gtest versions require >=C++14 (and pzstd tries to find a system-installed gtest for its tests). |
felixhandte
changed the title
-std=c++11 When Default is Older
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than remove the flag entirely, as proposed in #3499, this commit uses the newest C++ standard the compiler supports. This retains the selection of using only standardized features (excluding GNU extensions) and keeps the recency requirements of the codebase explicit.
Tested with various versions of
g++andclang++.