Support Per Stream String Buffers in Velox Writer #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@macvincent has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89938211. |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
) Summary: Pull Request resolved: facebookincubator#392 Differential Revision: D89938211
macvincent
force-pushed
the
export-D89938211
branch
from
468c69c to
dfc58a3
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Dec 30, 2025
) Summary: Integrates the per-stream string buffer infrastructure (from D89933055) into the Velox Writer, enabling string fields to use per-field buffers instead of a shared global buffer. This architectural change enables incremental memory reclamation during chunking operations, improving memory efficiency for string-heavy workloads. The feature is controlled by a global [JustKnob](https://www.internalfb.com/intern/justknobs/?name=dwio%2Fnimble%3Adisable_shared_string_buffers). When the knob returns true, per-stream string buffers are enabled. When set to false (default), the existing shared buffer behavior is preserved. Differential Revision: D89938211
macvincent
force-pushed
the
export-D89938211
branch
from
dfc58a3 to
b511653
Compare
Summary: Adds per-stream string buffer support to Nimble's StreamData infrastructure. Previously, string data buffers were managed externally, but now each MutableStreamData instance can own its own Buffer for string content, enabling better memory isolation and lifecycle management with chunking. Differential Revision: D89933055
) Summary: Integrates the per-stream string buffer infrastructure (from D89933055) into the Velox Writer, enabling string fields to use per-field buffers instead of a shared global buffer. This architectural change enables incremental memory reclamation during chunking operations, improving memory efficiency for string-heavy workloads. The feature is controlled by a global [JustKnob](https://www.internalfb.com/intern/justknobs/?name=dwio%2Fnimble%3Adisable_shared_string_buffers). When the knob returns true, per-stream string buffers are enabled. When set to false (default), the existing shared buffer behavior is preserved. Differential Revision: D89938211
macvincent
force-pushed
the
export-D89938211
branch
from
b511653 to
f706f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D89938211