fix(rust-plugins): 🐛 upate ci config to release packages#125
Conversation
WalkthroughThis PR removes an outdated changelog entry for the WASM plugin while updating changelogs and version numbers for three plugins: compress, mdx, and wasm. It also introduces minor formatting adjustments and new artifact upload steps in the GitHub Actions workflows, and expands the release workflow to process an additional package. Changes
Sequence Diagram(s)sequenceDiagram
participant CI as "GitHub Actions Runner"
participant Workflow as "Build Workflow"
participant Artifact as "Artifact Service"
CI->>Workflow: Start build process
Workflow->>Workflow: Format steps and check mdx artifact path
alt mdx artifact exists
Workflow->>Artifact: Upload mdx artifact
else
Workflow->>Workflow: Skip mdx upload
end
Workflow->>Workflow: Check compress artifact path
alt compress artifact exists
Workflow->>Artifact: Upload compress artifact
else
Workflow->>Workflow: Skip compress upload
end
sequenceDiagram
participant CI as "GitHub Actions Runner"
participant Release as "Release Workflow"
participant Processor as "Artifact Processor"
CI->>Release: Trigger release process
Release->>Processor: Process package list (including compress)
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build.yaml (1)
72-72: Commented-Out Git Fetch Command:
The commented-outgit fetchcommand on line 72 has been reformatted. Since this code is inactive, consider removing it if it’s no longer needed, or add a clarifying comment regarding its potential future use to avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.changeset/shy-glasses-sparkle.md(0 hunks).github/workflows/build.yaml(3 hunks).github/workflows/release-rust-plugins.yml(1 hunks)rust-plugins/compress/CHANGELOG.md(1 hunks)rust-plugins/compress/package.json(1 hunks)rust-plugins/mdx/CHANGELOG.md(1 hunks)rust-plugins/mdx/package.json(1 hunks)rust-plugins/wasm/CHANGELOG.md(1 hunks)rust-plugins/wasm/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/shy-glasses-sparkle.md
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: call-rust-build / Build and Upload Artifacts - win32-arm64-msvc
- GitHub Check: call-rust-build / Build and Upload Artifacts - win32-ia32-msvc
- GitHub Check: call-rust-build / Build and Upload Artifacts - darwin-arm64
- GitHub Check: call-rust-build / Build and Upload Artifacts - linux-arm64-gnu
- GitHub Check: call-rust-build / Build and Upload Artifacts - linux-arm64-musl
- GitHub Check: call-rust-build / Build and Upload Artifacts - win32-x64-msvc
- GitHub Check: call-rust-build / Build and Upload Artifacts - darwin-x64
- GitHub Check: call-rust-build / Build and Upload Artifacts - linux-x64-musl
- GitHub Check: call-rust-build / Build and Upload Artifacts - linux-x64-gnu
🔇 Additional comments (11)
rust-plugins/wasm/CHANGELOG.md (1)
3-7: Clear Version Update & Patch Note
The new changelog entry for version 0.0.8 clearly documents the rewrite—especially noting the enhanced capability to parse WASM binary imports. Ensure that this version bump remains in sync with the update inrust-plugins/wasm/package.json.rust-plugins/compress/CHANGELOG.md (1)
1-7: Well-Formatted Changelog for Compress Plugin
The introduction of version 0.0.2 along with the clear note "update ci config to release packages" is concise and follows the project's changelog conventions. No further changes are necessary here.rust-plugins/mdx/package.json (1)
3-3: Accurate Version Bump
Updating the version from"0.0.6"to"0.0.7"is correct and aligns with the changelog modifications. Confirm that any references to this package version elsewhere are updated if necessary.rust-plugins/wasm/package.json (1)
3-3: Consistent Version Update for WASM Plugin
The change to version"0.0.8"is consistent with the changelog entry and accurately reflects the new functionality.rust-plugins/mdx/CHANGELOG.md (1)
3-7: Clear Changelog Entry for MDX Plugin
The new version 0.0.7 entry with the patch note "update ci config to release packages" is well documented and follows the established format.rust-plugins/compress/package.json (1)
3-3: Version Bump Update:
The"version"field has been updated to"0.0.2", which aligns with the intended release. Please ensure that this change is also reflected in the corresponding changelog and that it complies with the project's semantic versioning standards..github/workflows/release-rust-plugins.yml (1)
38-38: Inclusion ofcompressin Artifact Move Step:
Thecompresspackage has now been added to the list in the artifacts moving loop. Verify that the expected directory structure (./rust-plugins/compress/npm/${{ matrix.settings.abi }}) exists and that the build process for the compress plugin produces the required artifact..github/workflows/build.yaml (4)
93-95: Formatting Consistency for OS X Cross Setup:
Theosx-versionparameter is now wrapped in double quotes, which is consistent with YAML styling best practices and improves readability.
97-98: Uniform Version Formatting for Zig Setup:
Theversionfor the Zig setup is now set as"0.13.0"(using double quotes), ensuring consistency in string formatting across the workflow.
193-199: New Artifact Upload for mdx Plugin:
A new step has been added to upload artifacts for the mdx plugin. Please confirm that the build process correctly generates the artifact (index.farm) in the folder./rust-plugins/mdx/npm/${{ matrix.settings.abi }}and that downstream processes expect this file.
200-204: New Artifact Upload for compress Plugin:
This new step uploads artifacts for the compress plugin. Ensure that the build process generatesindex.farmin the directory./rust-plugins/compress/npm/${{ matrix.settings.abi }}, matching the patterns used by the other plugin upload steps.
3 participants
✅ Closes: #124
Summary by CodeRabbit