Conversation
WalkthroughVersion bumps to 0.1.0 across multiple rust plugins with corresponding CHANGELOG entries added. Several playground package.json files update devDependencies to @farmfe/core and @farmfe/plugin-react v2 beta (and one js-plugin-less nightly). A new CHANGELOG is introduced for modular-import. No code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 inconclusive)❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Flag potential breaking changes that are not documented:
1. Identify changes to public APIs/exports, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints (including removed/renamed items and changes to types, required params, return values, defaults, or behavior).
2. Ignore purely internal/private changes (e.g., code not exported from package entry points or marked internal).
3. Verify documentation exists: a "Breaking Change" section in the PR description and updates to CHANGELOG.md.Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (20)
rust-plugins/auto-import/playground-react/package.json (1)
20-21: Confirm intent: playground upgraded to Farm v2 beta while PR title says “update farm v1”.If the goal is v1 alignment, revert these to the latest v1 ranges; otherwise, consider updating the PR title/description to reflect v2-beta in playgrounds.
Proposed revert if staying on v1:
- "@farmfe/core": "^2.0.0-beta.0", - "@farmfe/plugin-react": "^2.0.0-beta.0", + "@farmfe/core": "^1.7.1", + "@farmfe/plugin-react": "^1.2.6",rust-plugins/auto-import/playground-vue/package.json (1)
17-17: Confirm intent: playground upgraded to Farm v2 beta while PR title says “update farm v1”.If sticking with v1 for this PR, revert to the previous v1 range; otherwise, adjust PR title/description accordingly.
Proposed revert if staying on v1:
- "@farmfe/core": "^2.0.0-beta.0", + "@farmfe/core": "^1.3.0",rust-plugins/mdx/CHANGELOG.md (1)
3-13: Consider “Minor Changes” for a feature entry.“feat: farm v1” reads as a feature; suggest changing the 0.1.0 section header from Patch to Minor if this wasn’t auto-generated by Changesets.
Apply if appropriate:
-### Patch Changes +### Minor Changesrust-plugins/react-components/CHANGELOG.md (1)
3-13: Changelog type nit: “feat” under Patch.If not auto-generated, switch 1.1.0 section to “Minor Changes” for feature work.
-### Patch Changes +### Minor Changesrust-plugins/svgr/CHANGELOG.md (1)
3-13: Changelog classification.“feat: farm v1” suggests Minor; update header if manual.
-### Patch Changes +### Minor Changesrust-plugins/modular-import/CHANGELOG.md (1)
1-13: New changelog looks good.File created with clear 0.1.0 and 0.1.0-beta.0 entries.
Optionally add release dates to headings for traceability.
rust-plugins/compress/CHANGELOG.md (1)
3-13: Feature labeled as Patch.If this wasn’t produced by Changesets, consider marking 0.1.0 as Minor.
-### Patch Changes +### Minor Changesrust-plugins/yaml/CHANGELOG.md (1)
3-14: Clarify “farm v1” scope and bump rationale in CHANGELOG.md
- Under
## 0.1.0, expand thefeat: farm v1entry with:
• Required@farmfe/core/runtimeversion constraints
• Whether this is a breaking change or fully compatible migration- Either add a
### Minor Changessection under0.1.0if any beta-period minor updates were promoted, or note explicitly that0.1.0only includes patch-level fixes over0.1.0-beta.0for consistencyrust-plugins/image/package.json (1)
3-3: Version bump looks consistent; add engines/publishConfig for smoother publishes.
- Consider adding engines to align with napi build matrix (e.g., Node >=16/18 as appropriate).
- If publishing to npm under an org, add:
"publishConfig": { "access": "public" }.- Optional: add
repository.directoryfor better npm metadata.Confirm Node support policy for these plugins and update
"engines"accordingly.rust-plugins/url/CHANGELOG.md (1)
3-14: Make the change description actionable.
- Replace “feat: farm v1” with a brief note like “Compatible with Farm v1.0; requires @farmfe/core >=1.x” (if true) and link to any migration notes.
rust-plugins/strip/CHANGELOG.md (1)
3-14: Consistent release notes formatting.
- Mirror the wording you choose in other packages for “farm v1” (requirements, breaking notes) to keep cross-plugin release notes uniform.
rust-plugins/image/CHANGELOG.md (1)
3-14: Add minimal upgrade guidance.
- Note any runtime/build changes when moving to Farm v1 (e.g., config keys, CLI flags), or explicitly state “no breaking changes” for this plugin.
rust-plugins/auto-import/CHANGELOG.md (1)
3-14: Spell out compatibility and impact.
- Clarify whether users need to change config/presets when upgrading to Farm v1, or confirm it’s a drop-in.
rust-plugins/wasm/CHANGELOG.md (1)
3-14: Carry forward prior breaking details if any.
- Given the earlier rewrite (0.0.8), explicitly state if 0.1.0 has no additional breaking changes beyond Farm v1 compatibility.
rust-plugins/virtual/CHANGELOG.md (1)
3-14: Uniform capitalization/terminology.
- Use a consistent label across packages (e.g., “feat: Farm v1 compatibility”) and, if applicable, add required core version.
rust-plugins/dsv/CHANGELOG.md (1)
3-13: Use “Minor Changes” for 0.1.0 and unify phrasing.
- “feat: farm v1” under “Patch Changes” is inconsistent; a feature should be “Minor Changes”.
- Align the pre-release and stable entries’ phrasing (e.g., “update to Farm v2 beta” vs “update farm v2-beta”).
Suggested diff:
-## 0.1.0 - -### Patch Changes - -- feat: farm v1 +## 0.1.0 + +### Minor Changes + +- feat: update to Farm v1rust-plugins/icons/CHANGELOG.md (1)
3-13: Changelog category and copy consistency.Same as dsv: “feat” should sit under “Minor Changes”, and copy should be consistent (“v2 beta” vs “v2-beta”).
Suggested diff:
-## 0.1.0 - -### Patch Changes - -- feat: farm v1 +## 0.1.0 + +### Minor Changes + +- feat: update to Farm v1rust-plugins/worker/CHANGELOG.md (1)
3-13: Adjust 0.1.0 to “Minor Changes”; normalize wording.Mirror the fixes applied to dsv/icons for category and phrasing consistency.
Suggested diff:
-## 0.1.0 - -### Patch Changes - -- feat: farm v1 +## 0.1.0 + +### Minor Changes + +- feat: update to Farm v1rust-plugins/react-components/playground/package.json (2)
14-14: Pin nightly to an exact version for repeatable builds.Caret on a nightly pre-release can drift. Prefer an exact version.
- "@farmfe/js-plugin-less": "^2.0.0-nightly-20250827162746", + "@farmfe/js-plugin-less": "2.0.0-nightly-20250827162746",
26-27: Future-proof: add an engines constraint (optional).If moving to Farm v2 requires Node >=18, declare it to prevent env drift.
Example:
"engines": { "node": ">=18" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (36)
rust-plugins/auto-import/CHANGELOG.md(1 hunks)rust-plugins/auto-import/package.json(1 hunks)rust-plugins/auto-import/playground-react/package.json(1 hunks)rust-plugins/auto-import/playground-vue/package.json(1 hunks)rust-plugins/compress/CHANGELOG.md(1 hunks)rust-plugins/compress/package.json(1 hunks)rust-plugins/compress/playground/package.json(1 hunks)rust-plugins/dsv/CHANGELOG.md(1 hunks)rust-plugins/dsv/package.json(1 hunks)rust-plugins/icons/CHANGELOG.md(1 hunks)rust-plugins/icons/package.json(1 hunks)rust-plugins/image/CHANGELOG.md(1 hunks)rust-plugins/image/package.json(1 hunks)rust-plugins/mdx/CHANGELOG.md(1 hunks)rust-plugins/mdx/package.json(1 hunks)rust-plugins/modular-import/CHANGELOG.md(1 hunks)rust-plugins/modular-import/package.json(1 hunks)rust-plugins/react-components/CHANGELOG.md(1 hunks)rust-plugins/react-components/package.json(1 hunks)rust-plugins/react-components/playground/package.json(2 hunks)rust-plugins/strip/CHANGELOG.md(1 hunks)rust-plugins/strip/package.json(1 hunks)rust-plugins/svgr/CHANGELOG.md(1 hunks)rust-plugins/svgr/package.json(1 hunks)rust-plugins/url/CHANGELOG.md(1 hunks)rust-plugins/url/package.json(1 hunks)rust-plugins/virtual/CHANGELOG.md(1 hunks)rust-plugins/virtual/package.json(1 hunks)rust-plugins/wasm/CHANGELOG.md(1 hunks)rust-plugins/wasm/package.json(1 hunks)rust-plugins/wasm/playground/package.json(1 hunks)rust-plugins/worker/CHANGELOG.md(1 hunks)rust-plugins/worker/package.json(1 hunks)rust-plugins/worker/playground/package.json(1 hunks)rust-plugins/yaml/CHANGELOG.md(1 hunks)rust-plugins/yaml/package.json(1 hunks)
🔇 Additional comments (15)
rust-plugins/worker/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/url/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/wasm/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/yaml/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/strip/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/dsv/package.json (1)
3-3: Version bump looks good.Package metadata only; no behavioral change implied.
rust-plugins/mdx/package.json (1)
3-3: Version bump looks good.
No functional change; semver aligns with the changelog narrative.rust-plugins/icons/package.json (1)
3-3: Version bump ACK.
No API surface changes in this diff.rust-plugins/modular-import/package.json (1)
3-3: Version bump ACK.
Matches the new changelog; no behavior change here.rust-plugins/react-components/package.json (1)
3-3: Minor version bump looks fine.
No other field changes.rust-plugins/svgr/package.json (1)
3-3: Version bump ACK.
No functional diffs here.rust-plugins/virtual/package.json (1)
3-3: Version bump ACK.
Consistent with the repo-wide 0.1.0 release.rust-plugins/auto-import/package.json (1)
3-3: Version bump acknowledged.0.0.9 → 0.1.0 with no API surface changes visible here.
rust-plugins/compress/package.json (1)
3-3: Version bump acknowledged.0.0.2 → 0.1.0; metadata unchanged.
rust-plugins/react-components/playground/package.json (1)
26-27: No action needed for Farm v2 beta compatibility
This playground intentionally targets Farm v2 beta (others like wasm, compress, auto-import, worker do the same). Specifying@farmfe/cli: "^1.0.2"already resolves to the latest 1.0 patch (≥1.0.4) which supports core 2.0.0-beta.0, and there is no CLI v2 release.
| "@farmfe/core": "^2.0.0-beta.2", | ||
| "@farmfe/plugin-react": "^2.0.0-beta.2", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Align beta versions across playgrounds and verify CLI compatibility.
Ensure all playgrounds use the same @farmfe/core and @farmfe/plugin-react beta to avoid subtle incompatibilities; also confirm @farmfe/cli ^1.x works with core ^2.0.0-beta.2.
Run to audit versions:
🏁 Script executed:
#!/bin/bash
# List core/react versions across all playground package.json files
fd -a package.json rust-plugins | rg playground | while read -r f; do
printf "%s\n" "$f"
jq -r '.devDependencies["@farmfe/core"], .devDependencies["@farmfe/plugin-react"]' "$f"
echo
doneLength of output: 1120
Align beta versions and fix typos in playground dependencies
- Bump all 2.0.0-beta.X playgrounds (auto-import, react-components, wasm, worker) to ^2.0.0-beta.2 and correct the “^2.0.0‐bate.0” typo in wasm/worker.
- Audit framework plugins per playground: use @farmfe/plugin-vue in Vue demos (plugin-react is irrelevant there).
- Verify @farmfe/cli ^1.x compatibility with core ^2.0.0-beta.2.
🤖 Prompt for AI Agents
In rust-plugins/compress/playground/package.json around lines 20 to 21, the
playground dependency versions and plugins are inconsistent: bump all playground
@farmfe/core entries to ^2.0.0-beta.2 (ensure auto-import, react-components,
wasm, worker match), fix any “^2.0.0‐bate.0” typos to ^2.0.0-beta.2, replace
@farmfe/plugin-react with @farmfe/plugin-vue in Vue demo package.json files
(plugin-react is irrelevant there), and confirm @farmfe/cli remains compatible
(or update its range) with core ^2.0.0-beta.2.
| "@farmfe/core": "^2.0.0-bate.0", | ||
| "@farmfe/plugin-react": "^2.0.0-bate.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Typo in version tag breaks installs: use "beta", not "bate".
Both deps will fail to resolve from the registry.
Apply this fix:
- "@farmfe/core": "^2.0.0-bate.0",
- "@farmfe/plugin-react": "^2.0.0-bate.0",
+ "@farmfe/core": "^2.0.0-beta.0",
+ "@farmfe/plugin-react": "^2.0.0-beta.0",Run to find other occurrences and confirm versions exist on npm:
🏁 Script executed:
#!/bin/bash
# Find all mistaken "bate" tags
rg -n --no-ignore -S '2\.0\.0-bate' -g '!**/node_modules/**' -C1
# Verify npm publishes for the intended beta tags
for pkg in @farmfe/core @farmfe/plugin-react; do
echo "Checking $pkg 2.0.0-beta.0 exists:"
curl -s https://registry.npmjs.org/$pkg | jq -r '.versions | has("2.0.0-beta.0")'
doneLength of output: 252
Use ‘beta’ instead of ‘bate’ in version tags
Apply this diff in rust-plugins/wasm/playground/package.json (lines 22–23):
- "@farmfe/core": "^2.0.0-bate.0",
- "@farmfe/plugin-react": "^2.0.0-bate.0",
+ "@farmfe/core": "^2.0.0-beta.0",
+ "@farmfe/plugin-react": "^2.0.0-beta.0",Matching the published 2.0.0-beta.0 versions avoids install failures.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@farmfe/core": "^2.0.0-bate.0", | |
| "@farmfe/plugin-react": "^2.0.0-bate.0", | |
| "@farmfe/core": "^2.0.0-beta.0", | |
| "@farmfe/plugin-react": "^2.0.0-beta.0", |
🤖 Prompt for AI Agents
In rust-plugins/wasm/playground/package.json around lines 22 to 23, the version
tags for "@farmfe/core" and "@farmfe/plugin-react" use the misspelled "bate"
instead of "beta"; update both version strings from "^2.0.0-bate.0" to
"^2.0.0-beta.0" so they match the published packages and avoid install failures.
| "@farmfe/core": "^2.0.0-bate.0", | ||
| "@farmfe/plugin-react": "^2.0.0-bate.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Same typo: "beta" vs "bate".
Will prevent dependency resolution.
Suggested fix:
- "@farmfe/core": "^2.0.0-bate.0",
- "@farmfe/plugin-react": "^2.0.0-bate.0",
+ "@farmfe/core": "^2.0.0-beta.0",
+ "@farmfe/plugin-react": "^2.0.0-beta.0",Use the script shared in rust-plugins/wasm/playground/package.json to scan the repo and verify npm availability.
🏁 Script executed:
#!/bin/bash
# Search for the typo across the repository
grep -R "2\.0\.0-bate\.0" -n . || true
# Inspect the worker playground package.json around the dependency lines
sed -n '1,50p' rust-plugins/worker/playground/package.json || true
# Display scripts in wasm playground package.json to identify scanning script
grep -R "\"scripts\"" -n rust-plugins/wasm/playground/package.json || true
# Inspect the wasm playground package.json content
sed -n '1,200p' rust-plugins/wasm/playground/package.json || trueLength of output: 1730
Fix typo in devDependencies versions
The entries in both rust-plugins/worker/playground/package.json and rust-plugins/wasm/playground/package.json use ^2.0.0-bate.0, which will prevent npm from resolving the packages. Update to ^2.0.0-beta.0 as shown:
- "@farmfe/core": "^2.0.0-bate.0",
- "@farmfe/plugin-react": "^2.0.0-bate.0",
+ "@farmfe/core": "^2.0.0-beta.0",
+ "@farmfe/plugin-react": "^2.0.0-beta.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@farmfe/core": "^2.0.0-bate.0", | |
| "@farmfe/plugin-react": "^2.0.0-bate.0", | |
| "@farmfe/core": "^2.0.0-beta.0", | |
| "@farmfe/plugin-react": "^2.0.0-beta.0", |
🤖 Prompt for AI Agents
In rust-plugins/worker/playground/package.json around lines 22 to 23, the
devDependency versions contain a typo "bate" instead of "beta"; update the
version strings from ^2.0.0-bate.0 to ^2.0.0-beta.0 (and mirror the same change
in rust-plugins/wasm/playground/package.json) so npm can resolve the packages
correctly.
1 participant
Summary by CodeRabbit