fix(index): check options.decorateReply is a boolean#178
Merged
Conversation
2 tasks
Member
|
Dont know well this component but the condition you mention seems consistent with the current type, isn't it a simple boolean check? |
decorateReply typeoptions.decorateReply is a boolean
Member
Author
It was checking if it's truthy but not explicitly a boolean. Have just updated the PR with a fix to reflect that. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
index.js:41
- The check should ensure that
options.decorateReplyis a boolean, not justtrue. Update the check totypeof options.decorateReply === 'boolean' && options.decorateReply.
if (options.decorateReply === true) {
Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
15d38b6 to
43d3551
Compare
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types state that the value should be a boolean, but the plugin is only checking if it is truthy.
This PR updates the
ifcondition to explicitly check it is boolean.Likewise, the PR updates the types to reflect that
decorateReplyis optional.Checklist
npm run testandnpm run benchmarkand the Code of conduct