Skip to content

build(deps-dev): replace standard with neostandard#282

Merged
Fdawgs merged 4 commits into
masterfrom
build/standard
Dec 12, 2024
Merged

build(deps-dev): replace standard with neostandard#282
Fdawgs merged 4 commits into
masterfrom
build/standard

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented Dec 8, 2024

See fastify/fastify-cors#340. This is a batch PR, so may have some issues. Please review changes.

@Fdawgs Fdawgs changed the title chore: add eslint.config.js build(deps-dev): replace standard with neostandard Dec 8, 2024
@Fdawgs
Copy link
Copy Markdown
Member Author

Fdawgs commented Dec 9, 2024

Test failures related to fastify/fastify#5637, TypeScript tests and/or types need updating to include required plugin params.

@Uzlopak
Copy link
Copy Markdown
Contributor

Uzlopak commented Dec 9, 2024

Do we need to wait for a release of fastify or do we need to fix something on plugin level?

@Fdawgs
Copy link
Copy Markdown
Member Author

Fdawgs commented Dec 9, 2024

Do we need to wait for a release of fastify or do we need to fix something on plugin level?

This is something we need to fix in the plugins. Either our type tests are missing mandatory/required plugin options, or the plugin option types are wrong and there are options that are required that should be optional.

See fastify/fastify-accepts#178 and fastify/fastify-autoload#425 where I've fixed it.

@Fdawgs Fdawgs merged commit 4b996a3 into master Dec 12, 2024
@Fdawgs Fdawgs deleted the build/standard branch December 12, 2024 20:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants