This repository was archived by the owner on Feb 27, 2024. It is now read-only.
Merged
Conversation
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Contributor
Author
|
wasmtime 10.0.0 has been released, so I'm opening this up for review. |
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
dicej
reviewed
Jun 20, 2023
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Looks good overall. Just wondering about the adapter binaries.
Collaborator
There was a problem hiding this comment.
Why aren't we building the adapter(s) from source anymore?
Contributor
Author
There was a problem hiding this comment.
Didn't think there was much advantage. The artifact we would get out would be what's checked in here, so why spend needless CPU time building them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades
spin-componentizeto wasmtime 10.0. We'll leave this in draft mode until wasmtime 10.0 is officially released and we can decide whether it's the right time to merge this.