Open
Conversation
kkasiacodeu
approved these changes
Jun 26, 2017
Collaborator
kkasiacodeu
left a comment
kkasiacodeu
left a comment
There was a problem hiding this comment.
Nice! The algorithm is good and I can't see any potential failures :)
Just one major comment on possible refactoring. But I'm approving this anyway, feel free to submit this as it is if you don't feel like doing the refactoring exercise :)
assignment3.py
Outdated
| class Dictionary(object): | ||
| def __init__(self, dictionary=None): | ||
| self.dictionary = [] | ||
| # self.prefixes = [] |
|
|
||
| visited.append([row_number,col_number]) | ||
|
|
||
| # left up |
Collaborator
There was a problem hiding this comment.
While this block of ifs is correct, can you maybe think of a more maintainable way to implement it? (Generalize all the 8 cases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.