-
Notifications
You must be signed in to change notification settings - Fork 0
Added assignment 3 code. Open for review :) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
figalit
wants to merge
2
commits into
master
Choose a base branch
from
assignment_3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| class Dictionary(object): | ||
| def __init__(self, dictionary=None): | ||
| self.dictionary = [] | ||
|
|
||
| def insert_words(self, word_list): | ||
| self.dictionary = word_list | ||
|
|
||
| def is_word(self, string): | ||
| return (string in self.dictionary) | ||
|
|
||
| def is_prefix(self, string): | ||
| for word in self.dictionary: | ||
| if len(word) >= len(string) and word[0:len(string)] == string: | ||
| return True | ||
| return False | ||
|
|
||
|
|
||
| result_set = [] | ||
| def solution(n_rows, n_columns, matrix, dict_object): | ||
| word_sofar = '' | ||
| for i in range(n_rows): | ||
| for j in range(n_columns): | ||
| visited = [] | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict_object, i, j, word_sofar, visited) | ||
|
|
||
| print(result_set) | ||
|
|
||
|
|
||
| def find_word_for_cell(n_rows, n_columns, matrix, dict, row_number, col_number, word_sofar, visited ):\ | ||
|
|
||
| word_sofar = word_sofar + matrix[row_number][col_number] | ||
|
|
||
| if(dict.is_word(word_sofar)): | ||
| # print(word_sofar) | ||
| result_set.append(word_sofar) | ||
|
|
||
| if(not dict.is_prefix(word_sofar)): | ||
| return | ||
|
|
||
| visited.append([row_number,col_number]) | ||
|
|
||
| # left up | ||
| if(row_number-1 >= 0 and col_number -1 >=0 and [row_number-1,col_number-1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number-1, col_number-1, word_sofar, visited) | ||
| # middle up | ||
| if(row_number-1 >= 0 and [row_number-1,col_number] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number-1, col_number, word_sofar, visited) | ||
| # right up | ||
| if(row_number-1 >= 0 and col_number +1 < n_columns and [row_number-1,col_number+1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number-1, col_number+1, word_sofar, visited) | ||
| # left middle | ||
| if( col_number -1 >=0 and [row_number,col_number-1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number, col_number-1, word_sofar, visited) | ||
| # right middle | ||
| if(col_number +1 < n_columns and [row_number,col_number+1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number, col_number+1, word_sofar, visited) | ||
| # left down | ||
| if(row_number+1 < n_rows and col_number -1 >=0 and [row_number+1,col_number-1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number+1, col_number-1, word_sofar, visited) | ||
| # middle down | ||
| if(row_number+1 < n_rows and [row_number+1,col_number] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number+1, col_number, word_sofar, visited) | ||
| # right down | ||
| if(row_number+1 < n_rows and col_number +1 < n_columns and [row_number+1,col_number+1] not in visited): | ||
| find_word_for_cell(n_rows, n_columns, matrix, dict, row_number+1, col_number+1, word_sofar, visited) | ||
|
|
||
|
|
||
| dictionary = Dictionary() | ||
| dictionary.insert_words(['CAR', 'CARD', 'CART', 'CAT']) | ||
| matrix = [['A', 'A', 'R'],['T', 'C', 'D']] | ||
|
|
||
| solution(2, 3, matrix, dictionary) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this block of ifs is correct, can you maybe think of a more maintainable way to implement it? (Generalize all the 8 cases)