feat: Add Annotated Tag Push Support#1051
Closed
fabiovincenzi wants to merge 17 commits intofinos:mainfrom
fabiovincenzi:push-tags
Closed
feat: Add Annotated Tag Push Support#1051fabiovincenzi wants to merge 17 commits intofinos:mainfrom fabiovincenzi:push-tags
fabiovincenzi wants to merge 17 commits intofinos:mainfrom
fabiovincenzi:push-tags
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 77.40% 81.52% +4.11%
==========================================
Files 56 57 +1
Lines 2288 2376 +88
Branches 258 292 +34
==========================================
+ Hits 1771 1937 +166
+ Misses 487 389 -98
- Partials 30 50 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # src/ui/views/OpenPushRequests/components/PushesTable.tsx # src/ui/views/PushDetails/PushDetails.tsx
jescalada
reviewed
Jul 28, 2025
Contributor
jescalada
left a comment
There was a problem hiding this comment.
Just leaving some comments after looking through the code, will update after testing the flow.
Contributor
There was a problem hiding this comment.
Just a heads up: looks like this'll have a lot of conflicts with the upcoming changes... Though, we probably want to merge this as a v2 feature anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces end-to-end support for annotated tag pushes
branchPushChainandtagPushChain.getChain()to select the correct chain based onaction.typeand presence ofaction.tag.Fixes #986