refactor: Refactor service module to TS + ESM#1063
Closed
jescalada wants to merge 22 commits intofinos:mainfrom
Closed
refactor: Refactor service module to TS + ESM#1063jescalada wants to merge 22 commits intofinos:mainfrom
service module to TS + ESM#1063jescalada wants to merge 22 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
+ Coverage 76.91% 77.38% +0.47%
==========================================
Files 55 54 -1
Lines 2270 2198 -72
Branches 255 346 +91
==========================================
- Hits 1746 1701 -45
+ Misses 494 445 -49
- Partials 30 52 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
By the way, @06kellyjac, the OIDC is still working correctly after your passport changes 👍🏼 I tried merging in your ActiveDirectory additions and refactoring them into TS, but I'm not sure if they work 100% as intended. Would appreciate a quick look at this to make sure! |
42 tasks
Contributor
Author
|
Closing this as #1166 is now available with the solved merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1062.
This PR is built on top of #977 which should merged first (and is ready to merge!).Note that some
.postrequests useres: anyinstead ofres: Response. For some reason, when usingres: Response, I was getting this (unhelpful) error:I have no idea why it seems to require the type
Application(from the Express library), but when setting it to typeanythe endpoints work as they used to.