refactor: Add TypeScript support#1142
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
- Coverage 83.40% 82.64% -0.77%
==========================================
Files 70 70
Lines 3007 3007
Branches 501 501
==========================================
- Hits 2508 2485 -23
- Misses 396 419 +23
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
left a comment
There was a problem hiding this comment.
Reapproving this - it's a lot easier to see the changes now that merge conflicts have been resolved 👍🏼
@coopernetes @06kellyjac I suppose this could go into the first release candidate for v2? Or should we deal with the few remaining TS PRs and get it all in a single release? #960 #1063 #1065
06kellyjac
left a comment
There was a problem hiding this comment.
Yes, moving to providing js and types from dist should be done in v2.
https://github.com/yeoman/generator/blob/main/package.json#L23-L37
Also there's several useful things within git-proxy which we expect people to directly import from files e.g. config, which would break & should be exported properly.
|
considering the majority of commits are just update merges and there's 2 commits with the same message a rebase & cleanup would be ideal |
|
|
5d176a2 to
8a1ebcf
Compare
|
Wondering if this is ready to go? 🤔 |
|
Hi @06kellyjac, what do you think about the latest changes? |
|
Given that @JamieSlome was covered by the Citi CCLA at the time the commits were made we can ignore the EasyCLA bot in this particular case. A @finos/git-proxy-maintainers should be able to force merge this PR. Please email help@finos.org with any questions or concerns. |
There was a problem hiding this comment.
There is a need to test a against the release publishing scripts before merging this as the @06kellyjac and I are both concerned that the changes to package.json will break import of types and running via the main entry.
I am unsure of the correct solution or why we modify the package when publishing...
kriswest
left a comment
There was a problem hiding this comment.
LGTM, my comments were dealt with. However, I'd appreciate @06kellyjac signing off on typescript config ;-)
|
To merge after we roll the next RC (which will hopefully be today) |
|
@finos-admin I believe this PR is ready to merge - only the EasyCLA check is missing! CC: @kriswest |
|
@06kellyjac could you approve this one then merge? Its still got you down as a requesting changes and is asking for a second reviewer: |
06kellyjac
left a comment
There was a problem hiding this comment.
There's still some complications from what I can see
Also with 38 commits can we get a squash please, many thanks.
955e58a to
e353b46
Compare
|
Plugin loader issues - we agreed to rip that out for now to be replaced. However, I'm not sure which PR that will/should happen in |
|
@kriswest The plugin loader tests now pass locally, but the ./plugin export in package.json points to src/plugin.ts, which references source files. We could leave it as is for now. Alternatively, I can skip these three tests if you prefer. |
|
@kriswest I'll do that in a separate PR - I'd suggest to just skip/remove the plugin test file since it's no longer relevant! |
|
We had 3 action items from the last meeting #1211 related to this PR:
Presumably the alst action is a different PR, so this one can just skip the tests? |
|
@fabiovincenzi was your slack comment indicating that this PR is ready for review again? |
@kriswest Yes |
kriswest
left a comment
There was a problem hiding this comment.
LGTM, but would like @06kellyjac to sign off as I trust his eyes on this better ;-)
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>
Signed-off-by: Fabio Vincenzi <93596376+fabiovincenzi@users.noreply.github.com>
|
@finos-admin hi, I can't see a force merge option, only to auto-merge once the check is complete prior conversation: #1142 (comment) |

Overview
This PR introduces TypeScript to git-proxy and refactors relevant code to support it.
Changelog
Thanks to @jescalada for the work on fixing CI issues on G-Research#31, which helped guide the necessary changes in this PR.
Related issue: #927
Note: Restored from deleted fork
This PR recreates the original PR #929, which was automatically closed due to accidental fork deletion.
** For discussions and reviews:** See the original PR #929
All commits are identical to the original with preserved git history.