refactor(ts): refactor db module to use TS and ESM #938
Closed
jescalada wants to merge 24 commits intofinos:mainfrom
Closed
refactor(ts): refactor db module to use TS and ESM #938jescalada wants to merge 24 commits intofinos:mainfrom
db module to use TS and ESM #938jescalada wants to merge 24 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
…-refactor-db-module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
===========================================
- Coverage 61.88% 51.70% -10.18%
===========================================
Files 49 48 -1
Lines 1805 1671 -134
Branches 0 53 +53
===========================================
- Hits 1117 864 -253
- Misses 688 790 +102
- Partials 0 17 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
coopernetes
reviewed
Apr 21, 2025
Contributor
coopernetes
left a comment
There was a problem hiding this comment.
Hi @jescalada not sure which PR caused all the conflicts but can you tidy your branch up and then re-request a review from me? Thanks!
Contributor
|
The db and config modules were modified as part of #960 so closing for now. If further conversion or refactoring is needed, we can either re-open or start a new PR. |
Member
|
@coopernetes - can you confirm the suggested version bump for the merge of #960? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #964.
This PR refactors the
dbmodule to use TS and ESM. It builds on top of #929 (the latest commits haven't been merged in yet).Original PR comment:
Edit: I've managed to get the tests to pass by using
mochaon the plugin tests andts-mochaon everything else. The only problem is that some recent tests are flaky on local (they seem to pass reliably in the CI):Edit 2: Fixed flaky tests in #945.
Thank you!