refactor(ts): refactor config module to TS#966
refactor(ts): refactor config module to TS#966jescalada wants to merge 14 commits intofinos:mainfrom
config module to TS#966Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
===========================================
- Coverage 61.88% 50.99% -10.89%
===========================================
Files 49 48 -1
Lines 1805 1655 -150
Branches 0 81 +81
===========================================
- Hits 1117 844 -273
- Misses 688 794 +106
- Partials 0 17 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @coopernetes, I believe these changes have already been merged in #960. I can close this PR and #938 if needed, or otherwise let me know if I should change anything. |
coopernetes
left a comment
There was a problem hiding this comment.
Same as #938 , need to resolve conflicts then I can give this a proper review. Thank you!
|
The db and config modules were modified as part of #960 so closing for now. If further conversion or refactoring is needed, we can either re-open or start a new PR. |
Fixes #964, along with #938.
This PR builds on the
dbrefactor PR (#938) and migrates/src/configfiles to TS and ESM. I modified the logic in src/config/file.ts to work with ESM imports. When using get/set exports, these don't refresh unless explicitly exporting the desired variable (in this case, configFile).Note: I'll take another look at this PR to merge in some CI fixes that I made to the other TS refactor PRs.
Changelog