Skip to content

refactor(ts): refactor config module to TS#966

Closed
jescalada wants to merge 14 commits intofinos:mainfrom
jescalada:refactor-config-module-ts-and-esm
Closed

refactor(ts): refactor config module to TS#966
jescalada wants to merge 14 commits intofinos:mainfrom
jescalada:refactor-config-module-ts-and-esm

Conversation

@jescalada
Copy link
Contributor

Fixes #964, along with #938.

This PR builds on the db refactor PR (#938) and migrates /src/config files to TS and ESM. I modified the logic in src/config/file.ts to work with ESM imports. When using get/set exports, these don't refresh unless explicitly exporting the desired variable (in this case, configFile).

Note: I'll take another look at this PR to merge in some CI fixes that I made to the other TS refactor PRs.

Changelog

  • Refactor /src/config/ to use TS and ESM

@netlify
Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 707ac3b
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/67ecd7f95d142c0008941709

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 70.27027% with 55 lines in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (83e814b) to head (707ac3b).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/db/file/pushes.ts 48.48% 17 Missing ⚠️
src/db/file/repo.ts 57.89% 16 Missing ⚠️
src/db/index.ts 40.74% 11 Missing and 5 partials ⚠️
src/db/file/users.ts 77.77% 4 Missing ⚠️
src/config/file.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #966       +/-   ##
===========================================
- Coverage   61.88%   50.99%   -10.89%     
===========================================
  Files          49       48        -1     
  Lines        1805     1655      -150     
  Branches        0       81       +81     
===========================================
- Hits         1117      844      -273     
- Misses        688      794      +106     
- Partials        0       17       +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada linked an issue Apr 2, 2025 that may be closed by this pull request
2 tasks
@coopernetes coopernetes self-assigned this Apr 7, 2025
@jescalada
Copy link
Contributor Author

Hi @coopernetes, I believe these changes have already been merged in #960. I can close this PR and #938 if needed, or otherwise let me know if I should change anything.

Copy link
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #938 , need to resolve conflicts then I can give this a proper review. Thank you!

@coopernetes
Copy link
Contributor

The db and config modules were modified as part of #960 so closing for now. If further conversion or refactoring is needed, we can either re-open or start a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor auxiliary backend modules into TS (config, db) [Migration] Convert Utility Functions to TS

3 participants