-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(cloud_firestore): allow negative timestamp values #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/cloud_firestore/cloud_firestore_platform_interface/test/timestamp_test.dart
Show resolved
Hide resolved
packages/cloud_firestore/cloud_firestore_platform_interface/test/timestamp_test.dart
Outdated
Show resolved
Hide resolved
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the related issue was quite informative
…st/timestamp_test.dart Co-authored-by: Mike Hardy <github@mikehardy.net>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
I don't the CLA bot is about me, I have one on file and have successfully submitted PRs here 🤔 |
|
@dackers86 can you double check you've signed the CLA again please, it might be due to a changed GitHub email or something. |
|
@mikehardy could you try signing the CLA once more? |
|
@googlebot I fixed it. (apparently github@mikehardy.net was not one of my alternate emails in my google organization for this user, but (weirdly!) I have successfully merged PRs here before. Go figure :-) ) |
|
@kroikie CLA all set now, I'm confused how it happened but I was able to fix. Onwards! |
Co-authored-by: Mike Hardy <github@mikehardy.net> Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Co-authored-by: Mike Hardy <github@mikehardy.net> Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Description
Negative values would throw an error with a value less than 0. This now allows for positive and negative values within a valid range.
Related Issues
Fixes #3545
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?