Skip to content

Conversation

@dackers86
Copy link
Member

@dackers86 dackers86 commented Sep 16, 2020

Description

Negative values would throw an error with a value less than 0. This now allows for positive and negative values within a valid range.

Related Issues

Fixes #3545

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Ehesp Ehesp changed the title @dackers86/negative timestamp values fix(cloud_firestore): allow negative timestamp values Sep 17, 2020
@Salakar Salakar marked this pull request as ready for review January 28, 2021 13:04
Copy link
Contributor

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the related issue was quite informative

…st/timestamp_test.dart

Co-authored-by: Mike Hardy <github@mikehardy.net>
@google-cla
Copy link

google-cla bot commented Jan 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jan 28, 2021
@mikehardy
Copy link
Contributor

I don't the CLA bot is about me, I have one on file and have successfully submitted PRs here 🤔

@Salakar
Copy link
Member

Salakar commented Feb 2, 2021

@dackers86 can you double check you've signed the CLA again please, it might be due to a changed GitHub email or something.

@kroikie
Copy link
Collaborator

kroikie commented Feb 3, 2021

@mikehardy could you try signing the CLA once more?

@mikehardy
Copy link
Contributor

@googlebot I fixed it.

(apparently github@mikehardy.net was not one of my alternate emails in my google organization for this user, but (weirdly!) I have successfully merged PRs here before. Go figure :-) )

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 3, 2021
@mikehardy
Copy link
Contributor

@kroikie CLA all set now, I'm confused how it happened but I was able to fix. Onwards!

@Salakar Salakar merged commit 6d21f44 into master Feb 3, 2021
@Salakar Salakar deleted the @dackers86/negative-timestamp-values branch February 3, 2021 13:29
Salakar added a commit that referenced this pull request Feb 3, 2021
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Salakar added a commit that referenced this pull request Feb 3, 2021
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
@firebase firebase locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timestamp.fromMillisecondsSinceEpoch() throws when calculating negative milliseconds.

6 participants