-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: cherry-pick various commits from NNBD for stable #4941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mike Hardy <github@mikehardy.net> Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Co-authored-by: Mike Hardy <github@mikehardy.net> Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
|
This is fully tangential but I noticed you've still got a separate "cancel workflow runs" action here https://github.com/FirebaseExtended/flutterfire/runs/1823207554 - like react-native-firebase used to have, which requires hard coding workflow IDs etc., but the cancel workflow action was extended some months (almost a year?) back so that you could put it in the workflow that should be cancelled, and it will auto-magically get the id for that workflow and cancel it, so you can avoid the separate step, and avoid magical workflow IDs in CI. |
|
Here is the actionable commit that could be ported: invertase/react-native-firebase@0c35772 |
Description
Cherry pick a bug fix for Firestore and a feature release for Auth onto the non-null-safety/stable release branch.
Related Issues
#3565
#4263
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?