Fix issues related to the track borders#5484
Merged
canova merged 3 commits intofirefox-devtools:mainfrom Jun 12, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5484 +/- ##
=======================================
Coverage 86.04% 86.04%
=======================================
Files 312 312
Lines 30368 30368
Branches 8299 8299
=======================================
Hits 26129 26129
Misses 3644 3644
Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
force-pushed
the
track-border-issues
branch
from
e4c3d5a to
b701676
Compare
julienw
approved these changes
Jun 6, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me, included in high-contrast mode.
Can you please change the comment in line 174 too? As it's not reflecting the situation after this patch.
src/components/timeline/Track.css
Outdated
Comment on lines
+170
to
+171
| /* We want the width to look like it's 150px, but need to substract the | ||
| * margin and the 1px border */ |
Contributor
There was a problem hiding this comment.
I think the comment is incorrect, it was copied from timelineTrackLabel.
It might be worth using variables for the global trrack's width (150px) and the local track's margin (15px), and still use a calc here for documentation purpose?
canova
force-pushed
the
track-border-issues
branch
from
1055614 to
a4ba7fe
Compare
Previously it was doing a lot more `calc`s because it was happening in the parent div. This commit changes the box-shadow into an inset box-shadow so we don't have to change the width all the time. But we still need to change the width once to remove the left border for the local tracks.
…ldren instead Adding the border to the children, so we can right click on the left track label and that would still open the context menu.
canova
force-pushed
the
track-border-issues
branch
from
a4ba7fe to
b40d197
Compare
Merged
canova
added a commit
that referenced
this pull request
Jul 11, 2025
Changes: [Nazım Can Altınova] Fix issues related to the track borders (#5484) [Nazım Can Altınova] Remove the active tab and origins views (#5483) [Julien Wajsberg] Automatically request reviews for dependency updates (#5490) [Julien Wajsberg] Update fetch-mock-jest to @fetch-mock/jest (#5488) [Steve Fink] Document marker filter syntax (#5493) [Nazım Can Altınova] Update all of jest 29.7.0 → 30.0.0 (major) (#5495) [Nazım Can Altınova] Order global tracks by activity and select the most active non-parent process by default (#5491) [Paul Adenot] Allow searching for HTTP response status in marker views (#5504) [Nazım Can Altınova] Expose a `totalMarkerDuration` function in console (#5507) [Nazım Can Altınova] 🔃 Sync: l10n -> main (July 11, 2025) (#5510) And thanks to our localizers: el: Jim Spentzos kab: ZiriSut tr: Grk tr: Selim Şumlu uk: Artem Polivanchuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5458.
This PR fixes these track border/horizontal separator issues:
First commit fixes the issue where it's not right clickable on the blue active thread indicator. It also tries to simplify this indicator by removing a bunch of
calcs.Second commit fixes the issue that it's not right clickable on the top border of the thread label.
Deploy preview / production