Expose a totalMarkerDuration function in console#5507
Merged
canova merged 2 commits intofirefox-devtools:mainfrom Jul 7, 2025
Merged
Expose a totalMarkerDuration function in console#5507canova merged 2 commits intofirefox-devtools:mainfrom
totalMarkerDuration function in console#5507canova merged 2 commits intofirefox-devtools:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5507 +/- ##
=======================================
Coverage 86.13% 86.13%
=======================================
Files 308 308
Lines 29673 29686 +13
Branches 8017 8022 +5
=======================================
+ Hits 25558 25571 +13
Misses 3525 3525
Partials 590 590 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julienw
approved these changes
Jul 4, 2025
Contributor
julienw
left a comment
julienw
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Just a few small comments for the test code!
Merged
canova
added a commit
that referenced
this pull request
Jul 11, 2025
Changes: [Nazım Can Altınova] Fix issues related to the track borders (#5484) [Nazım Can Altınova] Remove the active tab and origins views (#5483) [Julien Wajsberg] Automatically request reviews for dependency updates (#5490) [Julien Wajsberg] Update fetch-mock-jest to @fetch-mock/jest (#5488) [Steve Fink] Document marker filter syntax (#5493) [Nazım Can Altınova] Update all of jest 29.7.0 → 30.0.0 (major) (#5495) [Nazım Can Altınova] Order global tracks by activity and select the most active non-parent process by default (#5491) [Paul Adenot] Allow searching for HTTP response status in marker views (#5504) [Nazım Can Altınova] Expose a `totalMarkerDuration` function in console (#5507) [Nazım Can Altınova] 🔃 Sync: l10n -> main (July 11, 2025) (#5510) And thanks to our localizers: el: Jim Spentzos kab: ZiriSut tr: Grk tr: Selim Şumlu uk: Artem Polivanchuk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That was requested before from gecko engineers. They wanted an easier way to see the total duration of filtered markers.
Now with this new function, they can do things like
totalMarkerDuration(filteredMarkers).Deploy preview