Conversation
Rados13
reviewed
Nov 13, 2023
roznawsk
approved these changes
Nov 14, 2023
Rados13
approved these changes
Nov 14, 2023
|
|
||
| defp validate_s3_credentials(credentials) do | ||
| keys = Map.keys(credentials) | ||
| if @s3_kyes -- keys == [] and keys -- @s3_kyes, do: :ok, else: {:error, :component_validation} |
Contributor
There was a problem hiding this comment.
Isn't this if condition missing something?
Rados13
reviewed
Nov 15, 2023
| alias Jellyfish.{Client, Component, Peer, Utils} | ||
| alias Jellyfish.Exception.StructureError | ||
|
|
||
| @s3_kyes [:access_key_id, :secret_access_key, :region, :bucket] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fishjam-dev/fishjam#117